Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce z-index of the parent email banner #34592

Merged
merged 1 commit into from May 6, 2020
Merged

Reduce z-index of the parent email banner #34592

merged 1 commit into from May 6, 2020

Conversation

bethanyaconnor
Copy link
Contributor

The modal backdrop is at 1040 and we want that to appear in front of the parent email banner.

The old z-index was copied from the cookie banner. I think it's that high because of something on pegasus, plus it doesn't bring up a modal so the z-index can be ridiculously large.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor requested a review from daynew May 4, 2020 17:08
@bethanyaconnor bethanyaconnor merged commit 902822a into staging May 6, 2020
@bethanyaconnor bethanyaconnor deleted the fnd-1128 branch May 6, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants