Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the arrow buttons so they always display on one line. Especially on mobile. #34611

Merged
merged 1 commit into from May 6, 2020

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented May 4, 2020

Previously, when the visualization column was shrunk down to its minimum size, the arrow buttons on minecraft would display on two lines. This would be especially obvious on mobile where "minimum size" is the default.

Before
Screenshot_20200413-133202_Chrome

After
Screenshot_20200504-155916_Chrome

This improves the placement of the buttons for other apps too.

Before
ButtonPlacementOld

After
ButtonPlacementNew

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems safe to me, but it would be good to get some additional eyes on it who know the design & code here better.

@jmkulwik jmkulwik merged commit fc6cc26 into staging May 6, 2020
@jmkulwik jmkulwik deleted the fix-minecraft-buttons branch May 6, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants