Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTT (Staging > Test) [robo-dtt] #34635

Merged
merged 21 commits into from
May 5, 2020
Merged

DTT (Staging > Test) [robo-dtt] #34635

merged 21 commits into from
May 5, 2020

Commits on Apr 21, 2020

  1. Refactor span->label so clicking functionName selects the function

    Madelyn Kasula committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b163ad8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Add 'Select all functions' checkbox

    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a1c4783 View commit details
    Browse the repository at this point in the history

  2. Update tests to account for additional checkbox

    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    ef48aa2 View commit details
    Browse the repository at this point in the history

  3. Filter invalid functions from state.selectedFunctions and from select… 

    …/de-select all
    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    1258c0a View commit details
    Browse the repository at this point in the history

  4. Add fallback if comment is undefined

    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    1e7e774 View commit details
    Browse the repository at this point in the history

  5. Switch conditional order, only check if function is valid if it's sel… 

    …ected
    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    f461146 View commit details
    Browse the repository at this point in the history

  6. Unit test selecting/de-selecting functions

    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    1391464 View commit details
    Browse the repository at this point in the history

  7. Clean up boxChecked conditional / return early

    Madelyn Kasula committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    6568e3b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Merge branch 'staging' into lib-select-all

    Madelyn Kasula committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    cc20ffc View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Add clarification comments

    Madelyn Kasula committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    5b7d5d9 View commit details
    Browse the repository at this point in the history

  2. Add uniqueIds to element ids to ensure uniqueness

    Madelyn Kasula committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    2f65f59 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Use uniqueId for input id and label htmlFor attrs

    Madelyn Kasula committed May 4, 2020
    Configuration menu
    Copy the full SHA
    ca5359f View commit details
    Browse the repository at this point in the history

  2. change manage students secrets column headers and add tooltip

    @Erin007
    Erin007 committed May 4, 2020
    Configuration menu
    Copy the full SHA
    0336a36 View commit details
    Browse the repository at this point in the history

  3. customize show/hide secret button text based on logintype

    @Erin007
    Erin007 committed May 4, 2020
    Configuration menu
    Copy the full SHA
    5ccbc51 View commit details
    Browse the repository at this point in the history

  4. test that the password column shows when it should and has correct he… 

    …ader based on login type
    @Erin007
    Erin007 committed May 4, 2020
    Configuration menu
    Copy the full SHA
    7182e08 View commit details
    Browse the repository at this point in the history

  5. check the password cell contents for word, picture and email sections

    @Erin007
    Erin007 committed May 4, 2020
    Configuration menu
    Copy the full SHA
    307d44c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Merge branch 'staging' into lib-select-all

    Madelyn Kasula committed May 5, 2020
    Configuration menu
    Copy the full SHA
    955cc14 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #34599 from code-dot-org/section-setup-req-5 

    Section Setup:  req 5 - customize "secrets" wording based on login type
    @Erin007
    Erin007 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e888574 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #34412 from code-dot-org/lib-select-all 

    Add 'select all functions' checkbox to library export modal
    Madelyn Kasula committed May 5, 2020
    Configuration menu
    Copy the full SHA
    42e8a50 View commit details
    Browse the repository at this point in the history

  4. Revert "Add parent email to new contact rollups process"

    @bencodeorg
    bencodeorg committed May 5, 2020
    Configuration menu
    Copy the full SHA
    78d4d3d View commit details
    Browse the repository at this point in the history

  5. Merge pull request #34634 from code-dot-org/revert-34541-contact-roll… 

    …ups-parent-email

Revert "Add parent email to new contact rollups process"
    @bencodeorg
    bencodeorg committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6c23dfb View commit details
    Browse the repository at this point in the history