Updated mailers for facilitator workshops #34638
Conversation
islemaster
force-pushed
the
facilitator-mailer
branch
from
f96e750
to
9afb0e5
Compare
islemaster
changed the title
| @@ -98,13 +106,22 @@ def teacher_enrollment_reminder(enrollment, days_before: nil) | |||
| @pre_workshop_survey_url = enrollment.pre_workshop_survey_url | |||
| @is_first_pre_survey_email = days_before == INITIAL_PRE_SURVEY_DAYS_BEFORE | |||
|
|
|||
| from = from_teacher | |||
There was a problem hiding this comment.
Can we put this first part in an else so that we treat these as immutable values rather than overwriting them immediately in some cases?
| @@ -0,0 +1,82 @@ | |||
| - pre_work_url = 'https://docs.google.com/document/d/1mmBcMoRKO2TVxQSEEb-SxMnhuDZUkjE06tHa-8CGeyE/edit' | |||
There was a problem hiding this comment.
Is it expected that this is an /edit URL while the one just below is a /pub one?
There was a problem hiding this comment.
This is as provided in spec, and there isn't currently a "published" version of this document. I'm asking Megan if she'd like to publish this doc too.
|
|
||
| %p | ||
| Please have the following with you on the day of your session to ensure you | ||
| are able to participate fully. |
| = link_to 'this page', Pd::WorkshopMailer::SUPPORTED_TECH_URL | ||
| for more information regarding compatible operating systems and browsers. | ||
| We do not recommend bringing a tablet as your primary device. | ||
| %li Download the Zoom app (more information below) |
There was a problem hiding this comment.
. at end to be consistent with other bullets?
| @@ -65,8 +68,11 @@ PREVIEWS = %w( | |||
| teacher_enrollment_reminder__csf_intro_3_day | |||
| teacher_enrollment_reminder__csp_1_10_day | |||
| teacher_enrollment_reminder__csp_1_3_day | |||
| teacher_enrollment_reminder__csp_for_returning_teachers_10_day | |||
There was a problem hiding this comment.
These are just entries we forgot to add in previous PRs, yeah? No changes to CSP for returning teachers workshop mailers in this PR, right?
There was a problem hiding this comment.
That's correct - I didn't realize we had this script, and just ran across it while working on this update. I went ahead and updated the list of mailers it tests to reflect some recent additions.
There was a problem hiding this comment.
I wrote this script long ago to verify that email template changes don't have unexpected results. (For example, 1 partial template can be used in multiple emails that we are not aware of.) Not sure if it is helpful to anyone but me.
There was a problem hiding this comment.
Seems very useful, thanks Ha!
|
Just trying to understand...what did our enrollment receipts / reminders for facilitator training workshops look like before this change? |
|
Oh, good point Ben. I'll address other review feedback and then post before/after for these mailers as a record of the changes we're making. |
|
I've updated the PR description with before/after screenshots of the mailer previews. |
Customizes the facilitator workshop enrollment receipt and enrollment reminder emails, as spec'd here.
Testing story
Manually tested using local mailer previews. Verified with the
diff_email_previewsscript that no other mailers were changed.Enrollment receipt (Facilitator workshop):
Enrollment reminder (Facilitator workshop):
Reviewer Checklist: