Show library code in function tooltip #34675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
May 13, 2020
| <% linkText = "Show code" %> | ||
| <div class="tooltip-code-link"> | ||
| <a href="javascript:void(0);"> | ||
| <%= linkText %> |
There was a problem hiding this comment.
nit: this can be simplified by using the string literal directly. i.e. something like <% "Show code" %> (I don't think my syntax is exactly right)
I think linkText was created to shortcut an if statement, but is probably no longer needed.
jmkulwik
reviewed
May 13, 2020
| ); | ||
| } | ||
|
|
||
| if (tooltip.showCodeLink) { |
There was a problem hiding this comment.
Should this be an else if? i.e. It seems like we wouldn't want both, right?
jmkulwik
reviewed
May 13, 2020
| var projectLibraries = dashboard.project.getProjectLibraries(); | ||
| var libraryName = funcName.split('.')[0]; | ||
| var library = projectLibraries.find( | ||
| lib => lib.name === libraryName |
There was a problem hiding this comment.
nit: (definitely not required) - consider using library or something similar instead of abbreviated lib
jmkulwik
reviewed
May 13, 2020
| document.querySelector('#libraryFunctionTooltipModal') | ||
| ); | ||
| } | ||
| }.bind(this) |
There was a problem hiding this comment.
nit: Rather than binding, consider using arrow notation
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link in the function tooltip for library functions that says "Show code". Clicking the link opens the LibraryViewCodeModal
Links
Testing story
Reviewer Checklist: