Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SectionHiddenStage model #34816

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

uponthesun
Copy link

@uponthesun uponthesun commented May 15, 2020

Testing story

  • Drone test pass
  • Looking for recommendations on what to manually test, if anything

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@uponthesun uponthesun changed the title [WIP] Rename SectionHiddenStage model Rename SectionHiddenStage model May 15, 2020
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Winter!

For manual testing I would try:

  1. On a teacher account make a section that has some students in it
  2. Go to a script and hide a lesson
  3. Go into one of the students accounts and check that viewing that script you don't see that lesson

Let me know if you need more details

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea Dani -- I only see an eyes test (no regular ui test) for this feature: https://github.com/code-dot-org/code-dot-org/blob/4008770ce7c309df7ddb39ff5064e104d1222545/dashboard/test/ui/features/learning_platform/hidden_stages_eyes.feature#L4-L3 and the eyes test doesn't really do any validation besides the visual validation. I'm always worried someone will incorrectly accept a new baseline when that's our only end-to-end coverage.

@uponthesun uponthesun merged commit 12d0716 into staging May 19, 2020
@uponthesun uponthesun deleted the rename-section-hidden-stage branch May 19, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants