Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use channelId as element key instead of name #34833

Merged
merged 2 commits into from
May 19, 2020
Merged

Use channelId as element key instead of name #34833

merged 2 commits into from
May 19, 2020

Conversation

maddiedierker
Copy link
Contributor

Libraries can have the same name, so use channelId as the element key instead of the name.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

jmkulwik
jmkulwik approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix!!

@maddiedierker maddiedierker merged commit b9490b5 into staging May 19, 2020
@maddiedierker maddiedierker deleted the fix-title-key branch May 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @jmkulwik