record progress on bubble choice parent after completing its sublevel #34837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
approved these changes
May 20, 2020
| @@ -184,9 +184,28 @@ def track_progress_for_user | |||
| level_source_id: @level_source.try(:id), | |||
| pairing_user_ids: pairing_user_ids, | |||
| ) | |||
|
|
|||
| is_sublevel = !@script_level.levels.include?(@level) | |||
There was a problem hiding this comment.
Just to clarify my understanding - for bubble choice, we create a ScriptLevel for the parent level, for which @script_level.levels returns an array containing the parent level. Do the sublevels also have their own ScriptLevels?
There was a problem hiding this comment.
nope -- the hierarchy works like this:
- ScriptLevel contains 1 Level (or multiple levels, if using "level swapping")
- that Level can contain sublevels (if it is a
BubbleChoiceorLevelGroup) - sublevels do not have their own
ScriptLevels, but - sublevels do have their own
UserLevels (indexed on script + level + user)
it's not ideal... but it's better than it used to be :)
There was a problem hiding this comment.
That clears up my confusion. Thank you! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Description
in order to efficiently query progress for bubble choice levels, we want to store progress on the bubble choice level, rather than only on its sublevels.
Testing story
Added a unit test to verify progress is being recorded in both places.
Reviewer Checklist: