Make 'select all functions' bold #34858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
May 19, 2020
| selectAllFunctionsLabel: { | ||
| margin: 0, | ||
| fontSize: 20, | ||
| fontFamily: '"Gotham 5r", sans-serif' |
There was a problem hiding this comment.
Rather than setting the fontFamily, would it make more sense to set the fontWeight? I'm slightly concerned that explicitly setting the fontFamily could cause this to display as a different looking text font on certain browsers.
There was a problem hiding this comment.
i changed the fontFamily because that's the convention i've seen throughout apps/ -- are we using fontWeight as the convention instead now?
There was a problem hiding this comment.
Ahh I didn't realize we bundle Gotham as part of our app. This makes more sense now. It seems a little odd to me that we have sans-serif as a fallback here without making it bold. But I don't think this is a ship blocker for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was difficult to visually differentiate the "Select all functions" input from the function inputs, so making that header bold:
Links
Testing story
Reviewer Checklist: