-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize script edit #34863
Organize script edit #34863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, @dmcavoy !
end of each lesson. | ||
</p> | ||
<HelpTip> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious if it looks any different/worse without the <p>
, like this:
<HelpTip>Like this!</HelpTip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and it seems to work fine without the paragraph tag as long as all the text is supposed to be smushed together (not in 2 paragraphs or something). I'm going to leave it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! Looks like a great improvement, and great bang for buck.
Organizes the script edit page by:
Checked with the curriculum team and they were on board this change: https://codedotorg.slack.com/archives/CFGAVL2CA/p1589913488188600
Testing story
All existing tests should cover the behavior since this is just a re organizing of the page.
Reviewer Checklist: