Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize script edit #34863

Merged
merged 6 commits into from
May 19, 2020
Merged

Organize script edit #34863

merged 6 commits into from
May 19, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 19, 2020

Organizes the script edit page by:

  1. Using the HelpTip component so we don't have to clutter the page with help text
  2. Grouping the fields together into related groups

Checked with the curriculum team and they were on board this change: https://codedotorg.slack.com/archives/CFGAVL2CA/p1589913488188600

Screen Shot 2020-05-19 at 2 30 30 PM
screencapture-localhost-studio-code-org-3000-s-csd3-2019-edit-2020-05-19-14_48_52

Testing story

All existing tests should cover the behavior since this is just a re organizing of the page.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, @dmcavoy !

end of each lesson.
</p>
<HelpTip>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious if it looks any different/worse without the <p>, like this:

<HelpTip>Like this!</HelpTip>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and it seems to work fine without the paragraph tag as long as all the text is supposed to be smushed together (not in 2 paragraphs or something). I'm going to leave it for now.

Copy link

@uponthesun uponthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! Looks like a great improvement, and great bang for buck.

@dmcavoy dmcavoy merged commit 44510ad into staging May 19, 2020
@dmcavoy dmcavoy deleted the organize-script-edit branch May 19, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants