Foorm: allow emojis in submissions #34868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By changing the Foorm::Submission backing table to use utf8mb4 instead of utf8 encoding, we now support emojis in Foorm submissions.
breville
commented
May 19, 2020
Comment on lines
15
to
23
| before_validation :strip_emoji_from_answers | ||
|
|
||
| # Drops unicode characters not supported by utf8mb3 strings (most commonly emoji) | ||
| # from the submission answers | ||
| # We can remove this once our database has utf8mb4 support everywhere. | ||
| def strip_emoji_from_answers | ||
| # Drop emoji and other unsupported characters | ||
| self.answers = answers&.strip_utf8mb4&.strip | ||
| end |
There was a problem hiding this comment.
I can move this change to a followup PR before merging.
wjordan
approved these changes
May 19, 2020
Continue filtering emojis until our change to the table encoding is live.
|
It's interesting that when building this PR on my local machine, the character-encoding migration generated a text limit of 4294967295 (4 GB), but when we ran the same migration on staging, it generated a At any rate, that staging change was scooped here. |
breville
added a commit
that referenced
this pull request
May 20, 2020
Followup to the migration in #34868. Now that the migration is live, we can discontinue filtering emojis out of Foorm submissions. Also updates an annotation.
wjordan
added a commit
that referenced
this pull request
Nov 25, 2020
Followup to #34868 which modified DB connection settings causing databases to be created with utf8mb4 by default. This migration should bring settings in existing databases back in sync with the new default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the
Foorm::Submissionbacking table to useutf8mb4instead ofutf8encoding, we now support emojis in Foorm submissions.Successful submission as seen in
dashboard-console:Successful submission seen in facilitator results: