Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all lesson group positions are zero based #34970

Merged
merged 2 commits into from
May 27, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 26, 2020

Fixes an issue where non-user-facing lesson groups were 0 based when they should be 1 based. Tested locally that the change will update the lesson groups during the seed process.

Testing story

  1. Tested seeding locally
  2. Added validation that makes sure position is an integer greater than 0
  3. Updated the lesson group factory to set position for a new factory created lesson group

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dmcavoy !

@dmcavoy dmcavoy merged commit 83d4627 into staging May 27, 2020
@dmcavoy dmcavoy deleted the zero-base-lesson-grou branch May 27, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants