Limit Editing on Levelbuilder to only en-US Locale

[dmcavoy]

We had an issue where a levelbuilder was in a Spanish locale on levelbuilder. They went in and edited a script and when it saved it changed the name and description of the script to the Spanish version. This change got deployed and users for confused why their course was now in Spanish when their locale was not.

To prevent this we are going to limit editing of scripts, levels, etc on levelbuilder to only the en-US locale. If you try to perform an editing type action in another locale you will get redirected to the homepage and see a flash notice (see below).

This change will impact actions in the following controllers:
blocks_controller.rb
courses_controller.rb
datasets_controller.rb
level_assets_controller.rb
level_starter_assets_controller.rb
levels_controller.rb
libraries_controller.rb
script_levels_controller.rb
scripts_controller.rb
shared_blockly_functions_controller.rb
videos_controller.rb

Links

• jira

Testing story

I added a test to make sure you get redirected if you try to edit a script or a level in another locale besides en-US.

Reviewer Checklist:

• Tests provide adequate coverage
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[davidsbailey]

Great solution Dani! In addition to the test coverage you added, we also have at least one UI test covering the require_levelbuilder_mode_or_test_env pathway on the script edit page.

[davidsbailey]

thank you for pushing for this more general approach, Dani! I think this is quite likely to save us from another surprise unwanted translation somewhere besides the script and level edit pages.

[Hamms]

+1000

[davidsbailey]

new UI tests look good!

[Hamms]

This looks great!