Foorm: improve styling #34981
Merged
Foorm: improve styling #34981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the styling of matrix questions on both mobile (below 600px width) and larger (600px and wider). In the latter case, the question gets 40% of the width while the remaining space is divided evenly between however many options are provided. The heading font is also reduced in weight and size.
breville
added a commit
that referenced
this pull request
May 27, 2020
Followup to #34981 which improves the matrix question header more. By making its text smaller, we should reduce the frequency of words being split into new lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the styling of matrix questions on both mobile (below 600px width) and larger (600px and wider). In the latter case, the question gets 40% of the width while the remaining space is divided evenly between however many options are provided. The heading font is also reduced in weight and size. Layout on mobile is improved.
It also improves the styling of rating questions by centering them.
matrix
desktop
before
after
mobile
before
after
rating
before
after
Followup to #33852.