-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "stages" to "lessons" in i18n: Step 4 #35008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few more instances of stage:
in scripts.en.yml
, are those from something else? Do they matter?
Winters-MBP:code-dot-org winterdong$ grep -n "stage\:" dashboard/config/locales/scripts.en.yml
1538: stage: {}
2742: stage: {}
2747: stage: {}
3924: stage: {}
...
dashboard/app/dsl/script_dsl.rb
Outdated
@@ -270,22 +270,18 @@ def endvariants | |||
|
|||
# @override | |||
def i18n_hash | |||
i18n_stage_strings = {} | |||
i18n_lesson_strings = {} | |||
@lessons.each do |stage| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to get this stage
variable as well?
This change was to remove the plural key |
woohoo, glad to see these gone! |
Overall plan of attack:
Links
Testing story
Reviewer Checklist: