Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "stages" to "lessons" in i18n: Step 4 #35008

Merged
merged 9 commits into from
Jul 21, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented May 28, 2020

Overall plan of attack:

  1. Add all strings keyed by the term "stage" to crowdin under the key "lesson". (original: Rename "stages" to "lessons" in i18n: Step 1 #34854, second attempt: explicitly clone 'stage' strings to 'lessons' #35408)
  2. Wait for a sync; Crowdin will automatically duplicate translations for the new strings (I18n sync Down & Out 06/22 #35426)
  3. Update all I18n.t references currently using the key "stage" to use the new "lesson" translations (original: Rename "stages" to "lessons" in i18n: Step 3 #34878, second attempt: Revert "Revert "Rename "stages" to "lessons" in i18n: Step 3"" #35407)
  4. Remove old "stage" strings now that they are no longer used (this PR)

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner May 28, 2020 01:27
@Hamms Hamms requested a review from uponthesun July 6, 2020 22:52
Copy link

@uponthesun uponthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few more instances of stage: in scripts.en.yml, are those from something else? Do they matter?

Winters-MBP:code-dot-org winterdong$ grep -n "stage\:" dashboard/config/locales/scripts.en.yml
1538:          stage: {}
2742:          stage: {}
2747:          stage: {}
3924:          stage: {}
...

@@ -270,22 +270,18 @@ def endvariants

# @override
def i18n_hash
i18n_stage_strings = {}
i18n_lesson_strings = {}
@lessons.each do |stage|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to get this stage variable as well?

@Hamms
Copy link
Contributor Author

Hamms commented Jul 16, 2020

There's a few more instances of stage: in scripts.en.yml, are those from something else? Do they matter?

This change was to remove the plural key stages; I'm not sure where those keys are coming from, but I don't think they matter and they're definitely out of scope for this change.

@Hamms Hamms requested a review from uponthesun July 16, 2020 20:34
@Hamms Hamms merged commit 9d53560 into staging Jul 21, 2020
@Hamms Hamms deleted the rename-stages-to-lessons-step-4 branch July 21, 2020 22:45
@davidsbailey
Copy link
Member

woohoo, glad to see these gone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants