-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Levelbuilder Clean Up: Group video settings together #35042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first time looking at the level edit page and wow, I can see how these improvements are sorely needed!
…working outside of it" This reverts commit e267bff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @dmcavoy !
apps/Gruntfile.js
Outdated
@@ -594,6 +594,8 @@ describe('entry tests', () => { | |||
'./src/sites/studio/pages/datasets/edit_manifest.js', | |||
levelbuilder: './src/sites/studio/pages/levelbuilder.js', | |||
'levels/editors/_all': './src/sites/studio/pages/levels/editors/_all.js', | |||
'levels/editors/fields/_video': | |||
'./src/sites/studio/pages/levels/editors/fields/_video.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please put this in alphabetical order, after 'levels/editors/_studio'
and before 'libraries/edit'
Group together the video settings in levelbuilder level edit pages.