Only allow the process that created the pidfile to remove it #35069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because apparently worker processes will call their parent's `at_exit` when they themselves exit. See grosser/parallel#230
7 tasks
|
#35225 merged with a fix for this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because apparently worker processes will call their parent's
at_exitwhen they themselves exit. See grosser/parallel#230Testing story
I found this error because the new i18n sync down process uses the parallel gem, and it broke when run with the
bin/i18n/sync-all.rbscript which usesonly_one. I also updated that script to independently work fine without this change, but before I did I verified that this change is sufficient for that to not break.Reviewer Checklist: