Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Levelbuilder Clean Up: Style improvements #35091

Merged
merged 7 commits into from Jun 5, 2020
Merged

Levelbuilder Clean Up: Style improvements #35091

merged 7 commits into from Jun 5, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 2, 2020 •
edited

1. Make headers stand out more by making them purple and also make them searchable

Screen Shot 2020-06-02 at 8 43 54 PM

2. Give video area a collapsable header

Screen Shot 2020-06-02 at 8 44 09 PM

3. Give sharing area a collapsable header

Screen Shot 2020-06-02 at 8 44 16 PM

4. Make sure all the triangles are consistent in which way they point for up or down

davidsbailey
davidsbailey approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for the separate commits!

@dmcavoy dmcavoy changed the base branch from standalone-video-edit to staging June 5, 2020 00:34
@dmcavoy dmcavoy merged commit 1ef6a6a into staging Jun 5, 2020
@dmcavoy dmcavoy deleted the small-style-improvement branch June 5, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@uponthesun uponthesun Awaiting requested review from uponthesun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmcavoy @davidsbailey