Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Teacher Only Box to Teacher Only Tab for CSP and CSD #35135

Merged
merged 4 commits into from Jun 9, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 4, 2020

Last year we added the Teacher Only Tab to hold the Teacher Only area for CSF levels. We are now ready to move CSP and CSD over to using this tab as well. I got the thumbs up from curriculum and PL.

Screen Shot 2020-06-03 at 8 48 04 PM

Testing story

Updated the TopInstructions Tests based on this change.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment on line 585/6 in TopInstructions also need to be updated?

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 8, 2020

Does the comment on line 585/6 in TopInstructions also need to be updated?

@Erin007 Good catch! I have updated and it should be fixed now. I also checked that both contained levels and normal programming levels work for both CSP, CSD and CSF locally.

@dmcavoy dmcavoy requested a review from Erin007 June 8, 2020 13:48
Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@dmcavoy dmcavoy merged commit 8ac4390 into staging Jun 9, 2020
@dmcavoy dmcavoy deleted the instructions-tabs branch June 9, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants