Null out the migrations from foreign key for script in section #35142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uponthesun
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
More context for people reading this in the future: we decided not to figure out a workaround to apply it in production, and instead to permanently revert, after discussing it with the Infra cabal. There are tradeoffs involved with foreign keys, and for larger tables we tend not to use them. Full discussion here: https://codedotorg.slack.com/archives/C03CK49G9/p1591119763381300
davidsbailey
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up work to null out migrations to add and then revert the foreign key for script_id on sections.
See revert PR for more details about the issue: #35088