Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable script_edit_page ui tests on iProducts #35146

Merged
merged 2 commits into from Jun 5, 2020

Conversation

davidsbailey
Copy link
Member

finishes https://codedotorg.atlassian.net/browse/PLAT-116

No reported failures or flakiness of this in #infra-test on this test in Firefox in the past 6 weeks, however it has been failing on iPad / iPhone. We don't really expect to be able to edit scripts on mobile devices anyway, so this PR just disables this test for those browsers.

Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good solution to me. Thanks for looking into it

@davidsbailey davidsbailey merged commit 2757274 into staging Jun 5, 2020
@davidsbailey davidsbailey deleted the no-mobile-script-edit branch June 5, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants