Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage rename cleanup #35165

Merged
merged 5 commits into from Jun 8, 2020
Merged

Stage rename cleanup #35165

merged 5 commits into from Jun 8, 2020

Conversation

uponthesun
Copy link

Removing all the old keys with "stage" in them accepted / returned by our APIs that we left in temporarily for compatibility with old cached versions of the JS.

Testing story

  • drone

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@uponthesun uponthesun merged commit 4c4f90e into staging Jun 8, 2020
@uponthesun uponthesun deleted the stage-rename-cleanup branch June 8, 2020 23:04
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up, @uponthesun ! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants