Fix pre-survey bug #35179
Fix pre-survey bug #35179
Conversation
| Workshop. | ||
| where(course: [COURSE_CSD, COURSE_CSP]). | ||
| where.not(subject: SUBJECT_FIT). | ||
| nearest_enrolled_in_by(current_user) |
There was a problem hiding this comment.
Is the nearest_attended_or_enrolled_in_by method poorly named? I would have thought that method does what you'd like (probably what you thought as well when you used it :).
There was a problem hiding this comment.
It's more stringent than named really. First it looks for the nearest workshop with attendance, then if it can't find one it looks for the nearest enrolled one. So a bit of a confusing name, yes
There was a problem hiding this comment.
I think such a change is probably out of scope for this bug fix, but maybe nearest_attended_else_enrolled_in_by? :)
There was a problem hiding this comment.
To be clear I'm talking about the old method, not your new one :) I guess I still don't understand, was the problem that the survey failed for teachers who have attended some other workshop in the past?
There was a problem hiding this comment.
Yeah the issue was if a teacher had attended another workshop previously it was trying to load a survey which didn't exist (ex. we don't have a foorm survey for academic year workshops). This was only an issue for the pre-survey because for everything else the teacher should have been marked attended for this workshop.
When a teacher goes to /pd/workshop_pre_survey without specifying an enrollment code, we look for the nearest workshop that they have attended, but this doesn’t match the workshop for a pre survey because they haven’t attended yet. For the pre survey, we will need to look up the nearest workshop they have enrolled in, instead.
This fix adds a new function that only looks up the nearest workshop they have enrolled in without regard for attendance.
Testing story
We reproduced the issue locally and validated the fix will show the user the correct survey instead of a 404.
Reviewer Checklist: