Revert bubble choice progress tab updates that weren't ready to go out #35180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
changed the title
| if (levels[levelIndex].sublevels) { | ||
| // TODO: import SMALL_DOT_SIZE from progressStyles | ||
| // TODO: make consistent with multiGridConstants | ||
| width = width + levels[levelIndex].sublevels.length * 18; |
There was a problem hiding this comment.
If these items are yet to be done, is this work captured anywhere else? If it's done, we probably don't need the comments :)
| @@ -168,39 +168,6 @@ def user_summary(user) | |||
| # if we have a contained level or BubbleChoice level, use that to represent progress | |||
| level = Level.cache_find(level_id) | |||
| sublevel_id = level.is_a?(BubbleChoice) ? level.best_result_sublevel(user)&.id : nil | |||
| if level.is_a?(BubbleChoice) # we have a parent level | |||
There was a problem hiding this comment.
it would be awesome to DRY this up by extracting lines 174-200 and 206-232, which are very similar, into a helper function.
| if completion_status == LEVEL_STATUS.not_tried | ||
| # for now, we don't allow authorized teachers to be "locked" | ||
| if locked && !user.authorized_teacher? | ||
| levels[level_id] = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally merged #34986 via the command line and then created a big ol' knot and couldn't revert cleanly. See this discussion for details.
I used
git checkout <commit> -- <files>to create this PR that reverses the changes in #34986