AFE eligibility logic #35192
Merged
AFE eligibility logic #35192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Jun 8, 2020
dashboard/app/models/school.rb
Outdated
| if stats.nil? || stats.frl_eligible_total.nil? || stats.students_total.nil? | ||
| return false | ||
| end | ||
| stats.frl_eligible_total.to_f / stats.students_total.to_f >= 0.5 | ||
| end | ||
|
|
||
| # determines if school meets Amazon Fugure Engineer criteria | ||
| # eligible if a) title I school, >40% URM, or >40% eligible for free and reduced meals |
There was a problem hiding this comment.
nit: is there supposed to be a b) etc.?
There was a problem hiding this comment.
Sorry think I meant to put the different criteria on different lines, will fix.
breville
reviewed
Jun 8, 2020
dashboard/app/models/school.rb
Outdated
| return false if stats.nil? | ||
|
|
||
| # To align with maker_high_needs? definition above, returning false | ||
| # if we don't have all data for a given school |
There was a problem hiding this comment.
super nit: please end sentences with . as it makes it a lot easier to read than when newlines might or might not imply end of sentence. :)
molly-moen
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schools are eligible for AFE benefits if they meet any of the following criteria:
Will be used in AFE eligibility flow -- skeleton of UI here.
Testing story
Added new unit tests in
Schoolmodel.Reviewer Checklist: