Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new columns to Summer workshop gsheet #35201

Merged
merged 3 commits into from Jun 8, 2020
Merged

Conversation

molly-moen
Copy link
Contributor

@molly-moen molly-moen commented Jun 8, 2020

PLC-902
Add new columns virtual and third_party_provider to the summer workshop gsheet export. The virtual column will either contain TRUE or be empty for a non-virtual workshop. As of now the only third party provider is Friday Institute, so that column will either contain friday_institute or be blank.
This will also update our workshop csv export.

Testing story

Tested via the process described here.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team June 8, 2020 18:23
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Probably worth noting that this also modifies our workshop dashboard CSV downloads. I think that's fine.

@molly-moen molly-moen merged commit 2595699 into staging Jun 8, 2020
@molly-moen molly-moen deleted the molly/virtual-column branch June 8, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants