Include subject on all PL Certificates #35211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Jun 8, 2020
| [ | ||
| { | ||
| string: workshop.course_name, | ||
| y: -10, |
There was a problem hiding this comment.
Will the removal of this part have an impact on any certificates that previously used a y of -10?
There was a problem hiding this comment.
My understanding could be incorrect, but I think it is ok because we always use the same certificate png, and the reason it was y of -10 for just the course name is we were centering the course name in the blank space, but for the new version we have two lines at y = -30 and y = 65 (course name and subject).
There was a problem hiding this comment.
Ah, this is a workshop-specific renderer, so should be fine.
breville
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only included a workshop subject on PL certificates for CSF courses. This change adds including subject on all PL certificates. Previously we also always added "Workshop" at the end of the subject for certificates, in this change don't add "Workshop" if the subject already contains the word "workshop" or if it is teachercon.
New certificates look like this:
Links
Testing story
Validated that certificates render correctly on Chrome, Firefox and Safari. Also updated unit tests to reflect change.
Reviewer Checklist: