New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete External .level files #35228

Merged

davidsbailey merged 1 commit into staging from remove-external-level-files

Jun 9, 2020

Member

davidsbailey commented Jun 9, 2020

these files which appear to be obsolete because:

Each of them are of type "External", which are supposed to be stored as DSL files ending in .external.
The files being removed were all created on the same day in Oct 2016 and have not been updated since then
each file being removed has a corresponding .external file which was updated more recently. in the cases I looked at, what you see in the level on levelbuilder matches the contents of the .external file, not the .level file

why this seems safe:

there is only one file being removed which corresponds to a level that's in any script:

code-dot-org/dashboard/config/scripts/csp5-2017.script

Line 20 in f2cb9b7

level 'CSPU5_FirstTimeDesignMode', progression: 'Introduction to Design Mode'

. I checked this one on levelbuilder specifically and confirmed that its contents matches the .external file, not the .level file.


          remove obsolete External .level files

1c645d4

davidsbailey requested a review from dmcavoy

June 9, 2020 06:55

dmcavoy approved these changes

View reviewed changes

Contributor

dmcavoy left a comment

Sounds good to me. Nice clean up Dave!

davidsbailey merged commit 3a09b54 into staging

davidsbailey deleted the remove-external-level-files branch

June 9, 2020 15:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment