Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style of code to match linter requirements #35230

Merged
merged 1 commit into from Jun 9, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 9, 2020

Updated the code to match the requirements of the linter. Error was:

'RAILS_ENV=staging RACK_ENV=staging bundle exec haml-lint dashboard pegasus' returned 65
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.0-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
dashboard/app/views/levels/editors/fields/_netsim_editors.html.haml:71 [W] HtmlAttributes: Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))
dashboard/app/views/levels/editors/fields/_netsim_editors.html.haml:79 [W] HtmlAttributes: Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))
dashboard/app/views/levels/editors/fields/_netsim_editors.html.haml:85 [W] HtmlAttributes: Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))

Checked that it looked the same before and after

Before
Screen Shot 2020-06-09 at 2 18 34 PM

After
Screen Shot 2020-06-09 at 2 18 51 PM

@dmcavoy dmcavoy merged commit 2491dba into staging Jun 9, 2020
@dmcavoy dmcavoy deleted the staging-failure-fix branch June 9, 2020 18:27
@davidsbailey
Copy link
Member

Hi @dmcavoy , just checking -- you have the commit hooks installed so that you get linter warnings on git commit, right? did this maybe slip through because you had to use git commit -n for something?

@dmcavoy
Copy link
Contributor Author

dmcavoy commented Jun 10, 2020

Hi @dmcavoy , just checking -- you have the commit hooks installed so that you get linter warnings on git commit, right? did this maybe slip through because you had to use git commit -n for something?

@davidsbailey Yes I have the linter. The error came up locally but since I had not edited the code and just moved it I didn't think I needed to fix it so I did --no-verify. Learned my lesson and in the future I will just fix it

@davidsbailey
Copy link
Member

ah that's annoying. thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants