Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data to printable parent letter #35299

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Conversation

dju90
Copy link
Contributor

@dju90 dju90 commented Jun 12, 2020

We recently have compiled (or completed with partners) some really strong research backing up the value of learning CS. We would like to add a reference to this research in the printable letter that teachers can send to parents of students in their section.

Because Code Break wrapped up this week, I also took the opportunity to remove references to Code Break and remove the associated strings as well.

Links

Testing story

  • manually tested locally

Screenshots

Before

before_highlighted

After

after_highlighted

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dju90 dju90 requested a review from Erin007 June 12, 2020 09:04
@dju90 dju90 requested a review from a team as a code owner June 12, 2020 09:04
@dju90 dju90 requested review from clareconstantine and removed request for Erin007 June 12, 2020 19:59
@dju90 dju90 changed the title Add data printable parent letter Add data to printable parent letter Jun 14, 2020
Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny comment! looks good!

@@ -1178,7 +1176,7 @@
"parentLetterStudentPrivacy": "Code.org's commitment to student privacy",
"parentLetterStudentPrivacyDetails": "Code.org assigns utmost importance to student safety and security. Code.org has signed the [Student Privacy Pledge]({pledgeLink}) and their privacy practices have received [one of the highest overall scores from Common Sense Media]({commonSenseLink}). You can find further details by viewing Code.org's [Privacy Policy]({privacyPolicyLink}).",
"parentLetterWhy": "Why computer science",
"parentLetterWhyDetails": "Computer science teaches students critical thinking, problem solving, and digital citizenship, and benefits all students, no matter what opportunities they pursue in the future. And learning to make interactive animations, code-art, games, and apps on Code.org encourages creativity and makes learning fun.",
"parentLetterWhyDetails": "[Six different studies show]({researchLink}): children who study computer science perform better in other subjects, excel at problem-solving, and are 17% more likely to attend college. Computer science teaches students critical thinking, problem solving, and digital citizenship, and benefits all students, no matter what opportunities they pursue in the future. And learning to make interactive animations, code-art, games, and apps on Code.org encourages creativity and makes learning fun.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny: there's a hyphen in the first "problem-solving"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, good point - according to https://www.dailywritingtips.com/hyphenation-in-compound-nouns, "such treatment is justified only when the compound modifies a following noun". I'll be sure to remove that from the other places where we added it too.

@dju90 dju90 merged commit 5ccabf9 into staging Jun 17, 2020
@dju90 dju90 deleted the add-data-printable-parent-letter branch June 17, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants