Libraries UI tests

[maddiedierker]

Adds UI test coverage for our new libraries feature. Also adds a copy of the environment configuration and S3 bucket policy for using cdo-v3-libraries in CI environments.

Links

• STAR-1000

Reviewer Checklist:

• Tests provide adequate coverage
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[maddiedierker]

@sureshc @uponthesun I fixed the new bucket policy in s3_buckets.yml (there were just a few syntax errors) and the changeset succeeded in CloudFormation. could you take a look to make sure the policy itself looks okay?

[uponthesun]

I only looked at the S3 policy and ui_tests.sh changes, but those look good to me, though it seems like the test isn't passing on Drone yet? It could be useful to manually edit the bucket policy while iterating on the UI tests via sshing to drone container, and then put it in the template afterwards.

Feel free to ping me on slack if you want to brainstorm on how best to do this.

[maddiedierker]

we don't add new S3 buckets + UI tests often, but adding the steps needed to do so here in case it comes up again:

• Add a bucket policy to the relevant bucket in S3. This can usually be copied from another bucket. (I copied this one from cdo-v3-sources since they have similar purposes.)
• Add that bucket policy to s3_buckets.yml so that it's stored in our codebase as well, not just in S3. (You'll need to convert the JSON in S3's UI to YAML, but there are other examples in s3_buckets.yml and throughout the codebase.)
• Update the DroneWorker IAM policy to also allow S3 requests to the relevant bucket. This has to be done from the codeorg-dev AWS account, not your personal account. This can also be copied from another bucket -- we followed the example of cdo-v3-sources again.
• Make sure your UI test is trying to access the correct directory within the S3 bucket. We have CI mapped to RAILS_ENV=test, so our code defaulted to looking at the libraries_test/ directory, and we had to specify the directory in ui_tests.sh.

thank you, winter and suresh, for all your help on this!

[jmkulwik]

Might not be possible, but should we also check if the library blocks are in the project?

[maddiedierker]

i started down that path, and it seemed a lot more complicated than it's worth

[jmkulwik]

Would you be able to add a test for Gamelab too?

[maddiedierker]

i definitely can, but it looks like libraries aren't enabled in Gamelab, so i'm not sure how much value that would add. since you're OOO this week, i'm going to leave as-is for now and we can decide if we want to refactor this when you're back

[jmkulwik]

Oops. I think we forgot to enable libraries in Gamelab. Shouldn't block this PR, but probably should happen at some point.

[maddiedierker]

@jmkulwik PTAL!