AFE Call to Action Part 1

[molly-moen]

Update AFE Call to Action based on spec for this year (this is Phase 2 in the spec). Changes made are:

• Add our new form to /amazon-future-engineer and remove donor teacher banners that existed on that page
• Remove consent checkbox (it is now covered by the full-length form)
• Remove call to AFE from banner--instead redirect to /amazon-future-engineer and scroll to our new form
• remove unnecessary API calls now that most of the work is done on the new form

The banner now looks like this:

The new form is embedded at the bottom of /amazon-future-engineer (see Next Steps for details on this)

Next Steps

For now I have just put the new form as-is on the /amazon-future-engineer page, which means it starts with "Am I Eligible?". We want to instead skip over this step. The ability to do that will be added to the new form soon so skipping over that step on /amazon-future-engineer will be done as a follow-up item.

Links

• spec
• jira

Testing story

Tested manually on different browsers for teachers who are and are not eligible for AFE.

Reviewer Checklist:

• Tests provide adequate coverage
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[bencodeorg]

Since this component is already here, assuming this PR won't actually make it visible for anyone yet? Does this.state.donorBannerName control who sees the banner?

[molly-moen]

yep donorBannerName will be null if the banner should not be shown

[bencodeorg]

I can't wrap my head around how donorTeacherBanner.js and the new amazon_future_engineer.js files interact. Can you help me understand?

[bencodeorg]

LGTM -- would maybe think about getting rid of donorTeacherBanner.js entirely if it's not used anywhere? Also may be worth having someone in @code-dot-org/plc look at least at the amazon_future_engineer.js file, asynchronous JS is not quite my jam yet :).

[molly-moen]

LGTM -- would maybe think about getting rid of donorTeacherBanner.js entirely if it's not used anywhere? Also may be worth having someone in @code-dot-org/plc look at least at the amazon_future_engineer.js file, asynchronous JS is not quite my jam yet :).

removed the donorTeacherBanner since it's now not used anymore

[dju90]

Is donorTeacherBanner.js not used in Phase 2 of the campaign (which is roughly similar in user flow to last year's campaign, where a donor teacher banner was shown on the dashboard, for select schools)?

[bencodeorg]

@dju90 I think the name of this PR is maybe misleading you a bit, this PR represents "Phase 2" of the spec, but is a "Part 1" of that phase :). It's not using donorTeacherBanner.js. Correct me if I'm wrong @molly-moen.

[molly-moen]

@dju90 I think the name of this PR is maybe misleading you a bit, this PR represents "Phase 2" of the spec, but is a "Part 1" of that phase :). It's not using donorTeacherBanner.js. Correct me if I'm wrong @molly-moen.

That's correct! We aren't using donorTeacherBanner anywhere but the homepage in phase 2 which means we don't need that wrapper anymore, which was used to embed the banner within markdown