Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maker] Add micro:bit category to Droplet toolbox #35342

Merged
merged 6 commits into from
Jun 18, 2020
Merged

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jun 16, 2020

  1. Renames the experiment from bett-demo to microbit
  2. Adds the micro:bit blocks to the droplet config
  3. Shows the Maker and micro:bit categories if the experiment is enabled. Shows the Maker and Circuit categories if the experiment is not enabled.
    Future work- detect which kind of board is plugged in to determine which category to show.

With Experiment:

Maker Category:
image
micro:bit Category:
image
image

Without Experiment:

image
image
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Do you want us to test it out before you merge?

@ajpal ajpal merged commit 60bebdf into staging Jun 18, 2020
@ajpal ajpal deleted the jun15-microbit branch June 18, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants