Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated files to reflect the new codebreak redirect. #35353

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Jun 16, 2020

A redirect from codebreaknow -> break was added as part of the content changes here: 95cead8. This caused a test to fail due to the 301 redirect http code. The test was quickly patched to expect a 301 code: #35348. However, now that the redirect has been added, codebreaknow should no longer exist and should be deleted.

This PR takes care of the cleanup of codebreaknow and updates the test to no longer use a workaround.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik merged commit 6c2704f into staging Jun 18, 2020
@jmkulwik jmkulwik deleted the fix-pegasus-test branch June 18, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants