DTL (Test > Levelbuilder): d09c5ea7 #35378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the "My Account" page, users can create a personal login or update their account's existing password. There is already a "Password confirmation" field where the user is supposed to type in their password again. However, on the backend we were not verifying that the password and password confirmation fields matched. This change makes sure we run password field validations when a user is trying to create or change their password.
…n only when spritelab is loaded.
…firmation Check password confirmation when setting/updating password
DTT (Staging > Test) [robo-dtt]
I18n sync In & Up 06/15
…2020 I18n sync Down & Out 06/15
DTT (Staging > Test) [robo-dtt]
We found that some levels were not showing the level completion dialog even after the game was won. This only occured when the level was a non-English level. We found that the levels had some javascript which was specifically looking for the string "You won!" or "You lose!". This change updates the levels to depend on boolean `hasWonGame` or `hasLostGame` flags.
…on-doesnt-work-for-i18n Bugfix - Some levels never end if the language is non-english.
DTT (Staging > Test) [robo-dtt]
…rveys Foorm: Add is_friday_institute variable
DTT (Staging > Test) [robo-dtt]
Updated spritelab migration to skip user-created animations and to run only when spritelab is loaded.
DTS (Levelbuilder > Staging) [robo-dts]
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.