Update to latest version of acmesmith #35379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACMEv1 is being end-of-lifed, which as of this month means it will now refuse to allocate new domains:
Fortunately, updating is relatively simple! The most significant change is that new acme wants you to define a directory rather than an endpoint; updating our local config file seems to be sufficient.
I should note that it's not 100% clear to me that
/directory
is actually the directory that we want, but I was successfully able to spin up an adhoc with it set to that value.Testing story
With these changes, I was successfully able to initialize an adhoc from #35371: https://adhoc-mikewu.cdn-code.org/
Reviewer Checklist: