Remove old scratch code #35438
Remove old scratch code #35438
Conversation
dmcavoy
requested review from
davidsbailey,
maddiedierker,
uponthesun and
islemaster
|
thank you for this, dani! looking at test failures, there are some Spritelab UI test failures that look related to this change. it looks like you should be able to go to also cc'ing *labs (@epeach @jmkulwik @ajpal) just in case any of them have context around scratch |
dashboard/app/models/game.rb
Outdated
| @@ -301,7 +296,6 @@ def channel_backed? | |||
| CurriculumReference:curriculum_reference | |||
| Map:map | |||
| CustomFlappy:flappy | |||
| Scratch:scratch | |||
There was a problem hiding this comment.
The order of this list matters, so removing this entry will probably break dance, spritelab, bubblechoice, and fish.
There was a problem hiding this comment.
Whats the best way to deal with this then? Then leave the entry?
There was a problem hiding this comment.
Yeah probably just leave it and add a comment
|
@madelynkasula @ajpal The change is now passing tests. Can you re-review? |
Before Sprite Lab, Scratch was considered as another option for replacing Play Lab and giving younger students more ability to make diverse projects. JoshL made a prototype of pulling scratch into our website. No one is using this to create content so I am recommending we remove it.
There were only 2 Scratch levels. One for testing. The other the base level for a new project to be created off of. The levels were not in any scripts.