CRv2: Process state attribute #35517
Conversation
hacodeorg
force-pushed
the
ha/cr-process-state
branch
from
73f2e2a
to
3fd4c9b
Compare
| def self.extract_state(contact_data) | ||
| # The priority is: school state > user state > form geo state | ||
| # US state in schools table is in abbreviation, must convert it back to state name. | ||
| school_state = extract_field_latest_value contact_data, 'dashboard.schools', 'state' |
There was a problem hiding this comment.
A user will only have one row here...why use latest value here and not in other processing steps?
There was a problem hiding this comment.
I'm trying to not use too many implicit assumptions here. We join users to school_infos then to schools to map an email (not user_id) to a school. There is a chance that an email is mapped to more than 1 school.
There was a problem hiding this comment.
This query returns 59 users with more than 1 school. It's a small number, but it means our data can sometime surprise us.
SELECT t.email, count(*) as hit, count(distinct s.id) as distinct_school
FROM schools AS s
INNER JOIN school_infos AS si ON s.id = si.school_id
INNER JOIN users AS t ON si.id = t.school_info_id
WHERE email > ''
GROUP BY email
HAVING distinct_school > 1
ORDER BY distinct_school desc
hacodeorg
force-pushed
the
ha/cr-process-state
branch
from
7324faf
to
ee3d599
Compare
| return {state: state_name} | ||
| end | ||
|
|
||
| user_state = extract_field_latest_value contact_data, 'dashboard.users', 'state' |
There was a problem hiding this comment.
This confused me for a while, because our User model doesn't have a column or method named state. I finally noticed that ContactRollupsRaw includes user_geos when it populates the dashboard.users source.
There was a problem hiding this comment.
We think of user_geos table as an extension of users table. So instead of doing 2 separate extraction, reading user_id from users table, and reading user location from user_geos (still has to join with users to get email address), we just do one join and get both user_id and user location.
PLC-918: Use contact's
stateto set Pardot prospect'sdb_State.statevalue is calculated fromdashboard.schools#state,dashboard.users#stateandpegasus.form_geos#state.Links
Speadsheet with all attributes to process.
Test story
See #35508.