Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AFE Integration: Handle submission failures #35569

Merged
merged 3 commits into from Jun 30, 2020
Merged

AFE Integration: Handle submission failures #35569

merged 3 commits into from Jun 30, 2020

Conversation

islemaster
Copy link
Contributor

@islemaster islemaster commented Jun 30, 2020 •
edited

Our controller correctly detects failed attempts to submit to AFE, logs them to Honeybadger, and response with BAD REQUEST.

I've also extracted a lot of our AFE submission logic to a service, to hide away details before we add a CSTA submission to this controller as well.

Links

The AFE integration TODO list.

Testing story

Covered by new unit tests and existing unit tests.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@islemaster islemaster changed the base branch from staging to afe-new-code-account June 30, 2020 03:58
@islemaster islemaster requested review from a team and Hamms June 30, 2020 04:00
Base automatically changed from afe-new-code-account to staging June 30, 2020 16:50
@islemaster islemaster merged commit d1dfb23 into staging Jun 30, 2020
@islemaster islemaster deleted the afe-detect-failure branch June 30, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@Hamms Hamms Awaiting requested review from Hamms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@islemaster @breville