Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to profanity filter route #35709

Merged
merged 3 commits into from Jul 9, 2020
Merged

Add caching to profanity filter route #35709

merged 3 commits into from Jul 9, 2020

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Jul 8, 2020

This adds caching to the profanity filter route. Currently, we check webpurify each time a student uses a project with playSpeech in it for the first time. This will cache those results so we don't make as many webpurify requests for the same text.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested a review from a team July 8, 2020 18:25
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🤬

@JillianK JillianK merged commit 94d250f into staging Jul 9, 2020
@JillianK JillianK deleted the profanity-caching branch July 9, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants