Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update international pd form in preparation for late-July Colombia teacher campaign #35715

Merged
merged 1 commit into from Jul 9, 2020
Merged

Update international pd form in preparation for late-July Colombia teacher campaign #35715

merged 1 commit into from Jul 9, 2020

Conversation

bethanyaconnor
Copy link
Contributor

From the Jira task:

  • change country multiple choice list to dropdown to save vertical space as more countries are added
    Screenshot 2020-07-08 at 12 32 03 PM

  • Add the "my organizer is not listed" option in the Workshop Organizer field to translation pipeline

  • Add "Computadores para Educar" to the Workshop Organizer field options
    Screenshot 2020-07-08 at 12 32 34 PM

  • Add a "Not applicable" option to the Workshop Facilitator and Workshop Course fields and ensure it is part of the translation pipeline
    Screenshot 2020-07-08 at 12 32 44 PM

I also added "My facilitator is not listed" to the translation pipeline.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review July 8, 2020 20:09
@bethanyaconnor bethanyaconnor requested a review from a team as a code owner July 8, 2020 20:09
Hamms
Hamms approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good catch on localizing the "not listed" strings

@bethanyaconnor bethanyaconnor merged commit eca751b into staging Jul 9, 2020
@bethanyaconnor bethanyaconnor deleted the international-pd-form-updates branch July 9, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bethanyaconnor @Hamms