AFE: move submit logging to server #35723
Conversation
| @@ -43,13 +58,13 @@ export default class AmazonFutureEngineerAccountConfirmation extends React.Compo | |||
| if you already have one. | |||
| </div> | |||
| <div style={styles.body}> | |||
| Already have a Code.org account? <a href={SIGN_IN_URL}>Sign in.</a> | |||
| Already have a Code.org account?{' '} | |||
| <a onClick={this.signInButtonPress}>Sign in.</a> | |||
There was a problem hiding this comment.
Removing the href may have changed the style of this link. I think, in this case, you could avoid that with href="#" or something - I don't feel bad about changing the hash since we're about to navigate.
There was a problem hiding this comment.
Nice, good to know will update! Main difference I see is that when you hover it gives you the clicky finger with an href, and the text cursor without it.
There was a problem hiding this comment.
fwiw, you can use cursor: pointer to show the clicky finger again.
| formData: submission_body | ||
| }.to_json | ||
| } | ||
| ) |
There was a problem hiding this comment.
Right now we're tracking this event if we successfully submit to AFE or if submitting to AFE is disabled for that environment. (But not if we skip submission or submission fails for some other reason.) That seems okay - is it the desired behavior?
There was a problem hiding this comment.
Yeah it was sort of for testing purposes, so I could see what would be sent to Firehose in development (since it sends Firehose requests to your logfile). Seems maybe useful in the future as well, to have the entire payload returned to the controller in development (instead of just immediately returning)?
Testing Story
Tested manually. I did have some issues where my
amazon_future_engineer_submitrequest would hang (and, as a result, the "Please wait..." message would show forever and the network request continued indefinitely), but I think that was a result of syntax errors I had in the controller logging action. Did not see that issue in several runs through the flow subsequently. But, keep an eye out when reviewing for anything that looks suspect.Reviewer Checklist: