Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the archived wiki page for oauth help #35780

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

islemaster
Copy link
Contributor

@islemaster islemaster commented Jul 13, 2020

Update the broken link in our developer OAuth setup help link (only visible in development).

Before After
before after

We were still linking to our old wiki, which went down years ago. The page in question has been archived here.

Testing story

Tested manually on local machine by signing out and visiting /users/sign_in.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@islemaster islemaster marked this pull request as ready for review July 13, 2020 18:04
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating this!

@islemaster islemaster merged commit 896608c into staging Jul 13, 2020
@islemaster islemaster deleted the update-oauth-help-link branch July 13, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants