Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spritelab] makeNumSprites block #35853

Merged
merged 1 commit into from Jul 20, 2020
Merged

[Spritelab] makeNumSprites block #35853

merged 1 commit into from Jul 20, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jul 16, 2020

Another low-lift, ceiling-raising block for Sprite Lab.
image
Makes the specified number of sprites at random locations
image

@ajpal ajpal requested a review from a team July 16, 2020 21:58
}
]
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the linter need a new line at the end of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all of the block config files are auto-generated through the levelbuilder UI and don't have the extra line at the end.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Thanks!

Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajpal ajpal merged commit ab2f775 into staging Jul 20, 2020
@ajpal ajpal deleted the jul16-spritelab-block branch July 20, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants