Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lesson groups to object set up in tests #35860

Merged
merged 8 commits into from Jul 18, 2020
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jul 17, 2020

Started this work in: #35787

In preparation for setting up script to be associated with lessons through lesson groups this makes sure that tests that set up scripts, lessons, or script_levels also have lesson groups set up. In addition it makes sure all the script->lesson_group->lesson->script_level associations are specified if missing.

Also did some renaming of stage to lesson.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right next step. Longer term, I think we will want to update the factories so that we get all of this automatically when creating objects with factories. It could be tricky to get this to work well in all cases, though.

@dmcavoy dmcavoy merged commit f4861f0 into staging Jul 18, 2020
@dmcavoy dmcavoy deleted the lesson-group-in-test branch July 18, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants