MicroBit Capacitive Touch #35864
Merged
MicroBit Capacitive Touch #35864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 29, 2020 16:21
ajpal
reviewed
Jul 17, 2020
| super(); | ||
| this.board = board; | ||
|
|
||
| // Flag to only trigger event on first of type |
There was a problem hiding this comment.
Can you clarify this comment?
ajpal
reviewed
Jul 17, 2020
| this.board = board; | ||
|
|
||
| // Flag to only trigger event on first of type | ||
| this.connect = false; |
There was a problem hiding this comment.
I read connect as a verb. Would isConnected or hasConnected make sense here?
ajpal
reviewed
Jul 17, 2020
| } | ||
|
|
||
| start() { | ||
| this.board.mb.streamAnalogChannel(this.board.pin); // enable temp sensor |
There was a problem hiding this comment.
temp? Should be captouch? (and below)
ajpal
reviewed
Jul 17, 2020
| this.readSensorTimer = setInterval(() => { | ||
| let currentValue = this.board.mb.analogChannel[this.board.pin]; | ||
| if (this.board.mb.analogChannel[this.board.pin] !== 255) { | ||
| if (currentValue > this.releaseReading + 200 && !this.connect) { |
There was a problem hiding this comment.
why + 200 here and + 100 below?
ajpal
reviewed
Jul 21, 2020
| if (this.board.mb.analogChannel[this.board.pin] !== 255) { | ||
| if ( | ||
| currentValue > this.releaseReading + this.connectedDelta && | ||
| !this.connect |
ajpal
approved these changes
Jul 21, 2020
added 2 commits
July 21, 2020 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Capacitive Touch functionality for the MicroBit. See API spec: https://docs.google.com/document/d/1oPqJpIsaaGIQv7_KvCShmw6i0mT6MP3VqBP41yZ5M5c/edit#heading=h.ak61axyp722j
Includes tests.
Includes droplet blocks in
Makertoolbox.Should only exist behind microbit experiment flag and droplet blocks only appear when using MicroBit and not CP.
Links
Testing story
Reviewer Checklist: