Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spanish translations for new colombian data #35866

Merged
merged 1 commit into from Jul 18, 2020
Merged

add spanish translations for new colombian data #35866

merged 1 commit into from Jul 18, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 17, 2020

So the form added in #35843 can be spanish-ready right off the bat, without waiting for a Crowdin sync.

We will need to also add these translations to crowdin once the source strings are uploaded.

Testing story

image

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner July 17, 2020 18:44
bethanyaconnor
bethanyaconnor approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good. Won't these strings be overridden by the sync though?

@Hamms
Copy link
Contributor Author

Hamms commented Jul 17, 2020

Yep! Hence the need for the followup work. I just wanted to get these in early since this feature is going to be in active use starting next week

Base automatically changed from colombian-schools to staging July 18, 2020 00:23
@Hamms Hamms merged commit a50807f into staging Jul 18, 2020
@Hamms Hamms deleted the colombian-school-translations branch July 18, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor