I18n sync In & Up 07/20 #35886
I18n sync In & Up 07/20 #35886
Conversation
| @@ -879,36 +712,36 @@ | |||
| "courseC_artist_loops5b_c": "Your program should look like this!\n\n[blockly block][0]" | |||
| } | |||
| }, | |||
| "https://studio.code.org/s/express-2020/stage/7/puzzle/10": { | |||
| "https://studio.code.org/s/express-2020/stage/6/puzzle/10": { | |||
There was a problem hiding this comment.
These changes make me nervous. Why did the URL change here?
There was a problem hiding this comment.
It looks like some levels were moved around in bb3cfd2#diff-dcf7270bfad7b445c0600cb9fdbdfedb. Because only express and pre-express were affected (which are generally made up of levels from a-f), it doesn't seem like this had major side effects. I'm also not seeing major side effects in #35887
There was a problem hiding this comment.
We were probably saved from major side effects by these strings being duplicates; if they were not, we would have lost translations.
I'm mostly worried here because this is a sign that our system for confirming that a course is finalized before enabling it clearly isn't working, if major changes like this are coming in after we've frozen. @dmcavoy do you happen to have context for why this happened?
There was a problem hiding this comment.
I don't you should ask Mike and Aaron what might have changed. I was under the impression we were not making changes like this anymore
I18n Sync In & Up
This PR contains all changes to internationalization source strings made since the last sync (usually a week).
To Review:
Look through the changes in each of the commits and verify that all changes are expected
We expect content changes to come in on a regular basis; individual strings will get updated, added, and deleted.
We do not usually expect to see "comprehensive" changes - or changes that apply to large numbers of strings or whole categories of strings all at once - unless we have made specific code changes.
Notify the International Partners team about any changes that might appear to manifest as "lost translations"
For example: https://github.com/code-dot-org/code-dot-org/pull/31031/files#diff-aa1910a8cf8f9290ae3baf7e39dbae3eL397-R398
This is a change that added new strings (with both new keys and new content) and simultaneously removed some very similar old ones; we can reasonably infer that the intent here was to swap the new strings out for the old ones. Unfortunately, because the swap also included a content change to the strings the crowdin duplication system won't automatically apply translations to the new strings and so they will need to be manually re-translated.
To Deploy:
Once one or two people have reviewed and approved this change and the tests are passing, ship it!
It's not necessary to wait for everyone on the team to review.