Add 59 new URLs to the broken link checker ignore list #35898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Jul 20, 2020
Comment on lines
+90
to
+94
| "http://www.youtube.com/watch?v=FC5FbmsH4fw", | ||
| "http://www.youtube.com/watch?v=MwLXrN0Yguk", | ||
| "http://www.youtube.com/watch?v=nKIu9yen5nc", | ||
| "http://www.youtube.com/watch?v=qYZF6oIZtfc", | ||
| "http://youtu.be/hfZrX5YDltU", |
There was a problem hiding this comment.
Is it possible we should ignore all youtube URLs?
There was a problem hiding this comment.
That thought has crossed my mind. It's certainly possible to have a broken youtube link (videos do get taken down) but the particular link checker tool we're using has a terrible time checking them accurately. I'm not sure why, exactly.
I'll fast-follow with this change.
breville
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 59 new URLs to the broken link checker ignore list, as requested by Mariah today.