Cleanup survey overview layout #35906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual 970px content width.
clareconstantine
approved these changes
Jul 21, 2020
mvkski
reviewed
Jul 21, 2020
|
|
||
| if (property === NOT_ANSWERED) { | ||
| percentValue = rowData.notAnswered; | ||
| } else { |
There was a problem hiding this comment.
hah, thanks! that one wasn't as simple as it looks. it turns out the PercentAnsweredCell defaults to -1 if percentValue is undefined, so we were relying on that line unsetting the value if we don't have a cell. imo much clearer to explicitly pass -1 in that case, hence my comment above.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
while looking into the missing data in the question detail dialog on the survey overview page, i noticed that the overview data was not visible because the question cells weren't wrapping text so to see the data you had to scroll way to the right.
once i resized everything to fit into our regular content width, i needed to refactor the
PercentAnsweredCellto properly center text when we're not including an icon.Testing story
I manually tested these changes on the CSD Unit 1 Pre-survey, and verified that the changes to
PercentAnsweredCelldid not impact how that component is used for a non-survey assessment.Reviewer Checklist: